Opened 4 years ago

Last modified 4 years ago

#3846 closed change

Add notification for users using an old SBrowser version — at Version 9

Reported by: mario Assignee: rjeschke
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29339199/

Description (last modified by rjeschke)

Background

Samsung released Samsung Internet (aka SBrowser) 4.0 for Android Lollipop which enables Lollipop users to use content blockers. (So far this has only been possible for Marshmallow users.)

Thus we're aiming for updating ABP for Samsung Browser in the Google Play Store to remove the restriction for Lollipop which enables Lollipop users to download and use ABP for Samsung Browser as well.
However if users using Lollipop haven't updated SBrowser to version 4.0 already and go ahead and download ABP for Samsung Browser, ABP won't work. Thus we need to detect the SBrowser version on ABP start-up and notify the user to update SBrowser if needed.

What to change

Implement a standard Android notification as shown in this workflow under Step 3 and reduce the minimum Android API version to 21 (Android 5).

The notification is shown on every ABP startup if all of the following requirements are met:

  • The user runs any Android version older than Marshmallow
  • The user runs any SBrowser version older than 4.0

The notification is not closable.

Ressources

Notification Text
Notification headline:
Update your browser

Notification body:
Before you can use Adblock Plus, you must update to Samsung Internet Browser 4.0.

After installing the update for Samsung Internet Browser, relaunch Adblock Plus to finish.

Notification button:
Get update

Change History (11)

Changed 4 years ago by mario

comment:1 Changed 4 years ago by mario

  • Description modified (diff)

comment:2 Changed 4 years ago by rjeschke

  • Component changed from Adblock-Browser-for-Android to Adblock-Plus-for-Samsung-Browser
  • Owner set to rjeschke
  • Platform changed from Adblock Browser for Android to Samsung Browser
  • Priority changed from Unknown to P2

comment:3 Changed 4 years ago by vickyyu

The Samsung Browser 4.0 is only going to be available for Android 5.0 and above, so the notification requirement "The user runs any Android version older than Marshmallow" should be revised to "The users runs any Android 5.0 and above" to exclude users with Android versions older than 5.0.

comment:4 Changed 4 years ago by vickyyu

  • Cc vickyyu added

comment:5 follow-up: Changed 4 years ago by scheer

Additionally the image shown for 'in this workflow under Step 3' is an iOS pop-up style guide (ABP_for_iOS_ALERT_v2.0.pdf). Was the wrong screenshot uploaded?

Changed 4 years ago by vickyyu

comment:6 Changed 4 years ago by vickyyu

  • Description modified (diff)

comment:7 in reply to: ↑ 5 Changed 4 years ago by vickyyu

Replying to scheer:

Additionally the image shown for 'in this workflow under Step 3' is an iOS pop-up style guide (ABP_for_iOS_ALERT_v2.0.pdf). Was the wrong screenshot uploaded?

Thanks! I've added the right screenshot (ABP_for_SamsungBrowser_First-run_V3.pdf) and updated the link in the description. I hope @rene has got the right one.

comment:8 Changed 4 years ago by rjeschke

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 4 years ago by rjeschke

  • Description modified (diff)
Note: See TracTickets for help on using tickets.