Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3851 closed change (fixed)

Implement subscribe link handling via process scripts

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #3499
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338861/

Description

Background

Our code handling clicks on abp:subscribe links pre-dates our current E10S code and has been implemented as a frame script. This isn't terribly efficient and uses a messaging approach which is different from all the other code.

What to change

Reimplement subscribe link handler as a child module (in a process script). It can listen to content documents being created and register its event handler for all of them.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/ed7a4cca3997

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Subscribe links work as expected.

ABP 2.7.2.4163
Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Last edited 3 years ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.