Opened on 03/21/2016 at 06:50:37 PM

Closed on 04/18/2016 at 05:54:55 PM

Last modified on 04/20/2016 at 08:26:59 AM

#3851 closed change (fixed)

Implement subscribe link handling via process scripts

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #3499
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Our code handling clicks on abp:subscribe links pre-dates our current E10S code and has been implemented as a frame script. This isn't terribly efficient and uses a messaging approach which is different from all the other code.

What to change

Reimplement subscribe link handler as a child module (in a process script). It can listen to content documents being created and register its event handler for all of them.

Attachments (0)

Change History (4)

comment:1 Changed on 03/21/2016 at 07:27:55 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/18/2016 at 05:54:07 PM by abpbot

A commit referencing this issue has landed:

comment:3 Changed on 04/18/2016 at 05:54:55 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 04/20/2016 at 08:25:56 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Subscribe links work as expected.

Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Last edited on 04/20/2016 at 08:26:59 AM by Ross

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.