Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3860 closed change (fixed)

Refactor and move request blocking logic to a seperate module

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338962

Description

Background

We recently made a great process moving code out of the global scope of the background page into modules. However, most notably the request blocking code is still left behind, and in order to further improve encapsulation it should be moved to a separate module as well.

What to change

  • Move the the request blocking logic from webrequest.js and the element collapsing logic from background.js into a new module.
  • Move the header based whitelisting logic from webrequest.js to the whitelistingmodule.
  • Unify the logic for detecting relevant filter changes for chrome.webRequest.onBahaviorChanged and to update the icon and context menu.

Change History (6)

comment:1 Changed 4 years ago by sebastian

  • Summary changed from Refactor and move request blocking logic to seperate module to Refactor and move request blocking logic to a seperate module

comment:2 Changed 4 years ago by sebastian

  • Owner set to sebastian

comment:3 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/0a96e28bffa6

comment:5 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Change has not caused any major regressions and blocking still works as expected.

ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.