Opened 5 years ago

Last modified 4 years ago

#3860 closed change

Refactor and move request blocking logic to seperate module — at Initial Version

Reported by: sebastian Assignee:
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29338962

Description

Background

We recently made a great process moving code out of the global scope of the background page into modules. However, most notably the request blocking code is still left behind, and in order to further improve encapsulation it should be moved to a separate module as well.

What to change

  • Move the the request blocking logic from webrequest.js and the element collapsing logic from background.js into a new module.
  • Move the header based whitelisting logic from webrequest.js to the whitelistingmodule.
  • Unify the logic for detecting relevant filter changes for chrome.webRequest.onBahaviorChanged and to update the icon and context menu.

Change History (0)

Note: See TracTickets for help on using tickets.