Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#3868 closed change (fixed)

Migrate the platform code to the new FilterNotifier API

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #3862, #3869
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29339020

Description (last modified by sebastian)

Background

With #3862, the FilterNotifier API got refactored and is now migrating to an event API similar to node.js. While the old methods are still supported, they are deprecated now, and the new API should also perform better.

What to change

  • Update adblockpluscore to enable and use the new FilterNotifer API (#3862).
  • Update adblockplusui to use the new FilterNotifer API (#3869).
  • Adapt platform code to use FilterNofier.on(), FilterNofier.off() and FilterNofier.emit().

Change History (6)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 4 years ago by sebastian

  • Blocked By 3862, 3869 added
  • Description modified (diff)

comment:4 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/045c2a14adaa

comment:5 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Subscriptions and filters are working without any obvious regressions.

ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.