#3869 closed change (fixed)
Migrate the UI to the new FilterNotifier API
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | #3868 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
With #3862, the FilterNotifier API got refactored and is now migrating to an event API similar to node.js. While the old methods are still supported, they are deprecated now, and the new API should also perform better.
What to change
Adapt existing code to use FilterNofier.on(), FilterNofier.off() and FilterNofier.emit().
Change History (6)
comment:1 Changed 4 years ago by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed 4 years ago by greiner
- Priority changed from Unknown to P3
comment:3 Changed 4 years ago by sebastian
- Blocking 3868 added
comment:4 Changed 4 years ago by abpbot
comment:5 Changed 4 years ago by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed 4 years ago by Ross
- Tester changed from Unknown to Ross
- Verified working set
Subscriptions and filters are working without any obvious regressions.
ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/9b91cdef871c