Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3872 closed defect (fixed)

"Block element" does not finish when popup window is closed

Reported by: kzar Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.12-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29339054

Description

Environment

Adblock Plus for Chrome as of https://hg.adblockplus.org/adblockpluschrome/rev/47cff5dab9c2

How to reproduce

  1. Click to block an element
  2. When the popup window opens close the window (with your window manager, not by clicking the "Cancel" button).

Observed behaviour

Element blocking is still in progress, the element is still highlighted red and the option to cancel is still given by the extension popup.

Expected behaviour

Element blocking should stop, like it did before.

Change History (6)

comment:1 Changed 4 years ago by sebastian

  • Owner set to sebastian
  • Priority changed from Unknown to P1
  • Ready set

Reproduced with the current development build. doesn't happen with Adblock Plus 1.11.

Version 0, edited 4 years ago by sebastian (next)

comment:2 Changed 4 years ago by sebastian

  • Summary changed from Element blocking does not finish when popup window is closed to "Block element" does not finish when popup window is closed

comment:3 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

This regression was introduced by f2c48546e442. Through all the rebasing, the name of the message to be sent when the popup is closed, got somehow reverted to it's former name.

comment:4 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/75435efcb391

comment:5 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

The Block element state now ends correctly if the popup is closed via window manager.

ABP 1.11.0.1597
Chrome 32 / 50 / Windows 10
Opera 23 / 36 / Windows 10
Chrome 32 / 50 / OS X 10.11
Opera 31 / 36 / OS X 10.11
Safari 6 / 7 / 9.1 / OS X 10.8/10.9/10.11
Chrome 50 / Ubuntu 14.04
Opera 36 / Ubuntu 14.04

Note: See TracTickets for help on using tickets.