Opened 4 years ago

Closed 4 years ago

#3884 closed change (fixed)

Show Subscription.title in advanced tab in new options page

Reported by: saroyanm Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian, athornburgh Blocked By: #2375
Blocking: #2372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339284

Description

Background

Currently we are showing the localizable title in advanced tab for filter lists while we should show same title as specified in the filter list itself.

What to change

Use Subscription.title to specify title for filter list in advanced tab.

Change History (5)

comment:1 Changed 4 years ago by greiner

  • Blocking 2372 added
  • Cc sebastian athornburgh added
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from show subscription.title for subscriptions in advanced tab [new options page] to Show Subscription.title in advanced tab in new options page

comment:2 Changed 4 years ago by sebastian

  • Owner set to sebastian

comment:3 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/23d02bf9ed77

comment:5 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.