Opened 4 years ago

Closed 4 years ago

#3889 closed change (fixed)

Dispatch subscription downloading event instead of downloadStatus when transfer begins

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, sebastian Blocked By:
Blocking: #3870 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339382

Description (last modified by kzar)

Background

Subscriptions dispatch a "subscription.downloadStatus" FilterNotifier event both when the begin downloading and when the download has finished. Unfortunately at the moment both have a downloadStatus of "sychronize_ok". (Assuming that it successfully downloaded.)

What to change

The onDownloadStarted hook in lib/synchronizer.js should dispatch a subscription.downloading event instead of a subscription.downloadStatus one.

Change History (6)

comment:1 Changed 4 years ago by kzar

  • Blocking 3870 added

comment:2 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by kzar

  • Description modified (diff)

comment:4 Changed 4 years ago by kzar

  • Description modified (diff)
  • Summary changed from Set downloadStatus for subscriptions to "in_progress" when they begin downloading to Dispatch subscription downloading event instead of downloadStatus when transfer begins

comment:5 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/719f4b374d89

comment:6 Changed 4 years ago by kzar

  • Priority changed from Unknown to P3
  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.