Opened 4 years ago

Last modified 4 years ago

#3889 closed change

Set downloadStatus for subscriptions to "in_progress" when they begin downloading — at Version 2

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: trev, sebastian Blocked By:
Blocking: #3870 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339382

Description

Background

Subscriptions dispatch a "subscription.downloadStatus" FilterNotifier event both when the begin downloading and when the download has finished. Unfortunately at the moment both have a downloadStatus of "sychronize_ok". (Assuming the last time it did successfully download.)

What to change

The onDownloadStarted hook in lib/synchronizer.js should instead change the subscription's downloadStatus property to in_progress. That way the event will automatically be dispatched, but with a more useful message.

Change History (2)

comment:1 Changed 4 years ago by kzar

  • Blocking 3870 added

comment:2 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.