Opened 4 years ago

Closed 4 years ago

#3890 closed defect (fixed)

Fix downloading indication for subscriptions on new options page

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, kzar Blocked By:
Blocking: #3870 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339387

Description

Background

The "Donwloading..." indication isn't shown for subscriptions when running in the extension. It is shown using the standalone mock implementation. That is because it artificially changes the lastDownload property when the download is started. However, in the real world, that doesn't happen. Instead the subscription.downloadStatus was dispatched until recently. Since #3889, subscription.downloading is dispatched instead. In both cases no property is actually changed.

What to change

Make sure that the download status on the new options page is updated on subscription.downloading.

Change History (6)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by kzar

  • Blocking 3870 added

comment:3 Changed 4 years ago by kzar

  • Priority changed from Unknown to P2

(Setting this as P2 as it's blocking a P2 issue.)

comment:4 Changed 4 years ago by greiner

  • Ready set

comment:5 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/500c80ee5bec

comment:6 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.