Changes between Version 4 and Version 5 of Ticket #3892, comment 9


Ignore:
Timestamp:
04/20/2017 07:11:18 PM (2 years ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3892, comment 9

    v4 v5  
    1 Custom filters are currently validated, both, when adding a single filter, and in raw edit mode, using [https://hg.adblockplus.org/adblockpluschrome/file/10bc96bbddd3/lib/filterValidation.js#l128 parseFilter()] and [https://hg.adblockplus.org/adblockpluschrome/file/10bc96bbddd3/lib/filterValidation.js#l169 parseFilters()] respectively. We definitely, have to retain this logic, not only to avoid unexpected results caused by user mistake, but more importantly because some invalid filters have a quite fatal impact (see the edit in my previous comment). 
     1Custom filters are currently validated, in both scenarios, when adding a single filter, and in raw edit mode, using [https://hg.adblockplus.org/adblockpluschrome/file/10bc96bbddd3/lib/filterValidation.js#l128 parseFilter()] and [https://hg.adblockplus.org/adblockpluschrome/file/10bc96bbddd3/lib/filterValidation.js#l169 parseFilters()] respectively. We definitely, have to retain this logic, not only to avoid unexpected results caused by user mistake, but more importantly because some invalid filters have a quite fatal impact (see the edit in my previous comment). 
    22 
    33Moreover, the solution that has been specified in this issue wasn't great, as the validation error was discarded but merely the button to add the filter should have been disabled, leaving the user clueless what their mistake was. I hope with the new design we manage to do better, showing the validation error.