Opened 4 years ago

Last modified 3 years ago

#3892 closed change

Disable button if input is invalid when adding subscriptions or filters — at Version 2

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339527

Description

Background

The old options page rejects empty or invalid URLs when adding subscriptions by URL. Currently, the new options page however doesn't prevent you from entering and empty or invalid URL when adding a subscription, causing further issues.

We came to the conclusion that disabling the button to add the subscription until a a valid URL has been entered would be the best user experience. For consistency, we should also disable the button to add a custom filter until a filter was entered.

What to change

Disable the buttons to add subscription or custom filter until the user entered a URL or filter respectively.

Change History (2)

comment:1 Changed 4 years ago by sebastian

  • Component changed from Unknown to User-Interface

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.