Opened on 04/07/2016 at 10:28:12 AM

Closed on 04/15/2016 at 04:55:15 PM

#3895 closed defect (fixed)

Artifacts in close icon on dialogs on the new options page

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #2355 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

How to reproduce

  1. Open the new options page
  2. Click on "add other website language" or "add other filter list"

Observed behavior

There are some artifacts below the close button's icon (i.e. the "x").

That is because the icon is actually just 8x8px, while the CSS sets it's dimensions to 12x12px, causing it to include some pixels of the icon below from the sprite. It also specifies incorrect sprite coordinates since the space between the icons is not part of any of them to avoid bleeding issues.

Expected behavior

The close icon should not include any pixels from other icons.

Attachments (1)

close-button.png (3.7 KB) - added by sebastian on 04/07/2016 at 10:28:24 AM.

Download all attachments as: .zip

Change History (9)

Changed on 04/07/2016 at 10:28:24 AM by sebastian

comment:1 Changed on 04/07/2016 at 10:34:34 AM by sebastian

  • Cc greiner added
  • Description modified (diff)

comment:2 Changed on 04/07/2016 at 10:35:55 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/07/2016 at 10:36:17 AM by sebastian

  • Description modified (diff)

comment:4 Changed on 04/07/2016 at 10:37:19 AM by sebastian

  • Description modified (diff)

comment:5 Changed on 04/07/2016 at 05:45:07 PM by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:6 Changed on 04/07/2016 at 05:47:36 PM by greiner

  • Blocking 2355 added

comment:7 Changed on 04/15/2016 at 04:54:01 PM by abpbot

A commit referencing this issue has landed:

comment:8 Changed on 04/15/2016 at 04:55:15 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.