Opened 4 years ago

Last modified 4 years ago

#3895 closed defect

Artifacts in close icon on dialogs on the new options page — at Version 3

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339552

Description (last modified by sebastian)

How to reproduce

  1. Open the new options page
  2. Click on "add other website language" or "add other filter list"

Observed behavior

There are some artifacts below the close button's icon (i.e. the "x").


That is because the icon is actually just 10x10px, while the CSS set's it's dimensions to 12x12px, causing it to include some pixels of the icon below from the sprite.

Expected behavior

The close icon should not include any pixels from other icons.

Change History (4)

Changed 4 years ago by sebastian

comment:1 Changed 4 years ago by sebastian

  • Cc greiner added
  • Description modified (diff)

comment:2 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by sebastian

  • Description modified (diff)
Note: See TracTickets for help on using tickets.