Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3901 closed change (fixed)

Open page in ABB via Safari app extension

Reported by: pavelz Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.4.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

We want to provide the possibility to open websites in ABB using the Safari web extension.

What to change

  1. In the Safari app extension show the ABB logo labeled "Adblock Browser" as shown in this screenshot.
  2. If the ABB logo in the Safari extension is tapped show an iOS modal dialog as shown in this screenshot.

Notification headline: "Open in Adblock Browser?"
Notification Text: <URL of the currently displayed website>
Notification button 1: "Cancel"
Notification button 2: "Open"

  1. If the notification button 1 is tapped, close the notification.
  2. If the notification button 2 is tapped, start ABB and open the previously in Safari displayed website in a new tab.

Remark for testers

The Safari app extension might not show all extensions by default. If the ABB logo is not shown during testing, tapp the "... More" button within the app extension and enable "Adblock Browser".

Attachments (2)

image1-4.PNG (274.8 KB) - added by mario 4 years ago.
image2-2.PNG (315.8 KB) - added by mario 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

IMPLEMENTED

Remarks for testers:

Use any app offering a "content sharing" activity which handles URLs - other web browsers, mail clients, twitter, facebook. When the activity shows up, find ABB icon. If it's not there yet, it must be activated in further selection under the last icon (three dots). Click ABB icon. A confirmation dialog will appear. When confirmed, ABB should pop up and open the URL in a new tab.

comment:2 Changed 4 years ago by mario

  • Description modified (diff)
  • Keywords icebox removed
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from Open page in browser via app extension to Open page in ABB via Safari app extension

During migrating backlog issues from Pivotal to Trac we've discovered that this specific issue has already been implemented. I hereby elaborate more on the implementation and assign it to the milestone when it was originally introduced.

I'll create a follow-up issue in order to change the wording of this feature.

Changed 4 years ago by mario

Changed 4 years ago by mario

comment:3 Changed 4 years ago by mario

  • Description modified (diff)

comment:4 Changed 4 years ago by pavelz

  • Milestone set to Adblock-Browser-for-iOS-next

comment:5 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

I tried this out on Facebook, Twitter, Gmail and Reddit with no issues. Of course, the user must sign back into the website once it is loaded in ABB, if the link is a direct one, to be able to see the content, but this is expected.

When the user selects the Safar app extension for ABB the dialogue below appears:

"Open in Adblock Browser?"
<URL of the currently displayed website>
"Cancel" "Open"

Selecting "Cancel" closes the dialogue and returns the user to the page in Safari.
Selecting "Open" opens the URL in ABB.

ABB 1.4.0 (966)
iPhone 6s Plus
iOS 9.3.1

comment:6 Changed 4 years ago by mario

  • Description modified (diff)
Note: See TracTickets for help on using tickets.