Opened 4 years ago

Closed 4 years ago

#3907 closed defect (fixed)

Title of Acceptable Ads subscription isn't shown on options page

Reported by: sebastian Assignee: sebastian
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339613

Description

Observed behaviour

With the mock implementation

When disabling Acceptable Ads and enabling it again the URL is shown instead of the title.

With the extension

The title of the Acceptable Ads subscription is never shown, falling back to its URL.

Background

This is a regression introduced by 0593d76f1106.

Expected behaviour

For the Acceptable Ads subscription, the translated title (i.e. "Allow some non-intrusive advertising") should always be shown.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Summary changed from Title of Acceptable Ads subscription isn't shown to Title of Acceptable Ads subscription isn't shown on options page

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/1056c35ec234

comment:4 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.