Opened 4 years ago

Closed 4 years ago

#3908 closed defect (fixed)

Broken website links on option page if subscription homepage isn't given

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339616

Description

Observed behaviour

For subscriptions that don't specify a homepage, the new options page is still showing a website link in the context menu on the Advanced tab. However, clicking the link, obviously doesn't have any effect.

Expected behaviour

The website link should be hidden for subscriptions that don't specify a homepage.

Change History (4)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/67941a4397e5

comment:4 Changed 4 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.