Opened 4 years ago

Closed 3 years ago

#3909 closed change (rejected)

Move "Tweaks" below "Filter lists" on new options page

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, saroyanm, wspee Blocked By:
Blocking: #2372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339619

Description

Background

Currently, on the new options page, at the top of the Advanced tab there is the Tweaks section with options that are quite rarely needed. So since we expect even advanced users using the Advanced tab mostly to manage filter lists, we decided to move the Tweaks section below the Filter lists section.

What to change

  • Move the Tweaks section to the bottom of the Advanced tab.
  • Improve the logic introduced with #3887, to automatically scroll down to the notification options in the Tweaks section.

Change History (5)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 3 years ago by greiner

  • Blocking 2372 added
  • Cc saroyanm added

comment:4 Changed 3 years ago by sebastian

  • Cc wspee added

Can I close this issue, and the related review, now, where we implement a whole different design?

comment:5 Changed 3 years ago by sebastian

  • Resolution set to rejected
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.