Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3912 closed change (fixed)

Provide HockeyApp Upload id for the new Devbuild appid

Reported by: pavelz Assignee: mario
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.4.0
Module: Adblock-Browser-for-iOS Keywords: provisioning
Cc: pavelz Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

A followup configuration of #3906.
Now there is technically two separate apps: a devbuild and a release build. The existing Devbuild in HockeyApp has become a Release build, because that's what the original app id says: org.adblockplus.AdblockBrowser. There is a new Devbuildregistration with appid org.adblockplus.devbuilds.AdblockBrowser, hence aligned to the established Adblock Plus Safari app. There is no app uploaded yet, for two reasons:

  1. there was no devbuild yet from the branch which has #3906 applied already
  2. the continuous integration scripts do not have the Upload token assigned yet

What to change

To enable building per reason 1, do reason 2: create HockeyApp Upload token for the new app registration
https://rink.hockeyapp.net/manage/apps/310687
and send it privately to Salsita.

Remarks for testers

The future devbuilds, i.e. with "Crash app" button and a changed app icon per #3911, must land in the new "Adblock Browser Devbuilds" group. The testing crash must land along that app upload.

Release builds, i.e. without the "Crash app" button and a regular app icon, must land in the original "Adblock Browser Release" app slot, not the "Devbuilds" slot. Any theoretical crashes must land along that app upload.

Change History (10)

comment:1 Changed 4 years ago by pavelz

  • Keywords provisioning added

comment:2 Changed 4 years ago by pavelz

  • Description modified (diff)
  • Summary changed from Provide HockeyApp Upload id for the new Release appid to Provide HockeyApp Upload id for the new Devbuild appid

comment:3 Changed 4 years ago by pavelz

Changed texting to reflect the fact, that the original app slot in HockeyApp must be retained as Release, not Devbuild. The made 1.3.0 Appstore release must be uploaded to HA to provide a crash report hook - and that is indeed a release with already hardcoded, previously existing HA app hash. So now the Devbuild app slot is newly created, not Release.

comment:4 Changed 4 years ago by mario

  • Cc pavelz added

Could you please update the link to the app?
https://rink.hockeyapp.net/manage/apps/310687 does either not exist or I have no privilege to see it.
As far as I can tell we can currently only provide upload tokens for the following two apps:

  • Adblock Browser Release, 185237
  • Adblock Plus Devbuild, 250362

Also do you need privileges for upload only or for releases as well?

comment:5 Changed 4 years ago by mario

  • Description modified (diff)

comment:6 Changed 4 years ago by pavelz

@mario try again please. There was no Eyeo team created yet, so i had to create one and add it to user pool of the newly created app slot (310687)

comment:7 Changed 4 years ago by mario

  • Priority changed from Unknown to P3
  • Ready set

comment:8 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:9 Changed 4 years ago by pavelz

  • Milestone set to Adblock-Browser-for-iOS-next

comment:10 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

Devbuilds with the "Crash app" button and a changed app icon now land in the new "Adblock Browser Devbuilds" group. The testing crash also lands in the same group-build version 'Crashes' section.

Release builds land in the original "Adblock Browser Release" app slot and not the "Devbuilds" slot. I have yet to check if crash reports from Release Builds land correctly in the 'Crashes' section of a Release build version due to no 'Force Crash' option and no 'real' crash yet occurring since this test.

ABB 1.4.0 (988)
iPhone 6s Plus
iOS 9.3.1

Note: See TracTickets for help on using tickets.