Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3931 closed defect (fixed)

Crash on filter list request/delivery

Reported by: rjeschke Assignee: rjeschke
Priority: P1 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.2
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: fhd, vickyyu Blocked By: #3953
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29340827/

Description (last modified by rjeschke)

There's a preference mismatch that is probably caused by using different Contexts for retrieving the SharedPreference object. This mismatch is causing a crash of the ContentProvider when SBrowser is trying to fetch the filters.

A two step solution is needed here:

  1. Fix the underlying issue that's causing this problem, i.e. the differing Context issue
  2. Fix the error in the preferences after it appeared, i.e. users might have already a corrupted preferences state, this must be checked and fixed (fixed via clean sweeping the preferences state)

Change History (12)

comment:1 Changed 4 years ago by vickyyu

  • Cc vickyyu added

comment:2 Changed 4 years ago by rjeschke

  • Blocked By 3953 added

comment:3 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:4 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:5 Changed 4 years ago by rjeschke

As the signing stuff is finally resolved, I will hopefully have a solution to this whole issue ready during tomorrow ... although I did not test the signed APK yet, I'm pretty confident that there shouldn't be any more issues on the signing front.

Fixing the rest is trivial and shouldn't take longer than a day.

comment:6 Changed 4 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by rjeschke

  • Priority changed from Unknown to P1

comment:8 Changed 4 years ago by rjeschke

  • Description modified (diff)

comment:9 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussbrowser/rev/699391e34c95

comment:10 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • No crashes have been observed when the user pushes for new filters.

ABP Sbrowser adblockplussbrowser-1.0.2-20160426113120-release
Sbrowser 4.0
Samsung Galaxy S5
Android Galaxy S7
Android 5.0
Android 6.0

comment:11 Changed 4 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 4 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.2
Note: See TracTickets for help on using tickets.