Opened 4 years ago

Closed 2 years ago

#3935 closed change (rejected)

Look into the possibility to include flash content on the screenshots

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Extensions-for-Adblock-Plus Keywords: abpcrawler
Cc: trev, tschuster Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29339735/

Description

Background

Currently the flash objects on screenshots are often transparent, e.g. check out http://waterlife.nfb.ca/#/, although it's not transparent on http://www.adobe.com/software/flash/about/.

We need to find out a way to have flash on the screenshot.

Change History (5)

comment:1 Changed 4 years ago by sergz

For reference, plugins.force.wmode does not help.

comment:2 follow-up: Changed 4 years ago by tschuster

I got this working with plugins.force.wmode: transparent, however in your example we take the screenshot too early and everything is still black. I verified this by using a timeout before calling gatherPageInfo in the child script.

comment:3 Changed 4 years ago by tschuster

  • Review URL(s) modified (diff)

comment:4 in reply to: ↑ 2 Changed 4 years ago by sergz

Sorry for confusion, plugins.force.wmode does work, however a reasonable delay is required.

comment:5 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.