Opened 4 years ago

Closed 2 years ago

#3940 closed change (rejected)

add CLI parameter to gather only filters

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Extensions-for-Adblock-Plus Keywords: abpcrawler
Cc: trev, fhd, philll, TobiasHilleke, tschuster Blocked By:
Blocking: #3936 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

In order to have #3936 we actually don't need screenshots and serialized content what cost a lot of disk space. It would save the disk space if we can limit the output only to the used filters.

What to change

Add CLI parameter "--only-filters" (run.py) and adapt accordingly JavaScript part.

Change History (2)

comment:1 Changed 4 years ago by trev

I think we should treat the data we save as modules which can be enabled and disabled individually, there will likely be more in future. Right now we seem to have four such modules, so the command line flags should be:

  • --enable-requests/--disable-requests
  • --enable-headers/--disable-headers
  • --enable-screenshots/--disable-screenshots
  • --enable-dom/--disable-dom

By default all these modules should be enabled, but we should be able to disable them individually as required.

comment:2 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.