Opened 4 years ago

Closed 2 years ago

#3941 closed change (rejected)

Set exact window size of Firefox window.

Reported by: sergz Assignee:
Priority: Unknown Milestone:
Module: Extensions-for-Adblock-Plus Keywords: abpcrawler
Cc: trev, TobiasHilleke, tschuster Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

Background

acceptable ads has a criterion regarding the size of ad, in particular what portion of visible space it occupies. To stay consistent in terms of the size of screenshots among runs of abpcrawler it would be good to set a window size according to the screen size mentioned in acceptable ads.

I guess, we may neglect the fact that at least fonts are differently rendered on different machines or after updates, the important thing is to distinguish between e.g. 3840x2160 and 1368x768 configurations.

What to change

Add CLI parameter for window size and call window.resizeTo(windowWidth, windowHeight); at the beginning of run function in crawler.js.

Change History (6)

comment:1 Changed 4 years ago by trev

I'd prefer to have this configurable rather than hardcoded. We can have a command line parameter defaulting to 1368x768. And we should start thinking about proper configuration files...

comment:2 Changed 4 years ago by sergz

  • Description modified (diff)

I also thought about it, however decided to don't mention it in this issue so far because if we decide to test it on different resolutions then according to https://adblockplus.org/acceptable-ads we should rather consider a possibility to test on or at least better emulate different platforms (mobile, tablet). Anyway, I have added it into the description.

comment:3 Changed 4 years ago by trev

The crawler is a general-purpose tool and not limited to Acceptable Ads, which is why this kind of settings generally should not be hardcoded. So not "ideally" but rather required.

comment:4 Changed 4 years ago by sergz

  • Description modified (diff)

comment:5 Changed 4 years ago by trev

  • Ready set

comment:6 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.