Changes between Initial Version and Version 1 of Ticket #394, comment 57


Ignore:
Timestamp:
04/05/2015 03:53:05 PM (5 years ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #394, comment 57

    initial v1  
    1 Another thing @saroyanm, if you want to test the collection works with the server in practice I've got a testing VM setup that you can use. If you grab an up to date copy of sitescripts, apply the [https://github.com/kzar/adblockplus-sitescripts/commit/edeef019cadc1cbf97a57748a7c903c6774c7cfd changes from this commit] and then type `vagrant up` you'll have a test server at `http://localhost:5000` to play with. You can then submit data to `http://localhost:5000` and query it back out with the interface at `http://localhost:5000/static/query.html`. 
     1Another thing @saroyanm, if you want to test the collection works with the server in practice I've got a testing VM setup that you can use. If you grab an up to date copy of sitescripts, apply the [https://github.com/kzar/adblockplus-sitescripts/commit/edeef019cadc1cbf97a57748a7c903c6774c7cfd changes from this commit] and then type `vagrant up` you'll have a test server at `http://localhost:5000` to play with. You can then submit data to `http://localhost:5000/submit` and query it back out with the interface at `http://localhost:5000/static/query.html`. 
    22 
    33I've already done this to test your work as of patch set 8, I left you a few comments on the review but it basically worked OK. You might want to re-test now that the 204 status code is returned though, or if you make further changes.