Changes between Version 1 and Version 3 of Ticket #3952


Ignore:
Timestamp:
04/18/2016 12:56:38 PM (4 years ago)
Author:
kvas
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3952 – Description

    v1 v3  
    22See #3949. 
    33 
     4Based on our experiments we decided to ignore E309 and E501 and E125 when doing the automatic reformatting. The reasoning is: 
     5* E309 -- adding an empty line before the first method in a class (except for the cases when the class has a docstring, that's E301). The empty line seems redundant, especially in the cases when the class has only one method. The absence of the empty line is not reported by `pep8`, so there's no reason to insert it. 
     6* E501 -- breaking up long lines. At the moment `autopep8` can't fix all long lines. Also, some of the fixes that it does actually make the code less readable and necessitate editing it by hand afterwards. To eliminate the prohibitive amount of manual work we choose to not fix the long lines for now. 
     7* E125 -- indentation of broken up lines. Fixing this leads to re-indentation of some code, which was originally PEP8-compliant, in a way that reduces readability. 
     8 
    49=== What to change === 
    510Run `autopep8 --ignore E309,E501,E125` on all Python code. Use `pydiff` to double check that the bytecode isn't changing.