Opened on 04/19/2016 at 12:31:37 PM

Closed on 04/19/2016 at 01:29:10 PM

Last modified on 04/20/2016 at 09:40:26 AM

#3955 closed change (fixed)

Set required ABP version properly when exporting filter lists with CSS property filters

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by trev)


Adblock Plus 2.7.3 for Firefox supports CSS property filters, the filter export functionality doesn't consider this yet.

What to change

Set required ABP version in header to 2.7.3 if CSS property filters are present in the list.

Hints for testers

This is about the Backup functionality in Filter Preferences (Ctrl/Cmd+E). When exporting you have to select "Custom filters only" as type, this will save a .txt file. The header of this file is something like [Adblock Plus 2.0] - this indicates that minimal required version is 2.0. It should be 2.7.3 if you have a custom CSS property filter.

Attachments (0)

Change History (5)

comment:1 Changed on 04/19/2016 at 12:37:15 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/19/2016 at 12:40:38 PM by trev

  • Description modified (diff)

comment:3 Changed on 04/19/2016 at 01:28:35 PM by abpbot

A commit referencing this issue has landed:

comment:4 Changed on 04/19/2016 at 01:29:10 PM by trev

  • Milestone set to Adblock-Plus-2.7.3-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 04/20/2016 at 09:40:26 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working as expected. Required version is 2.0, unless a CSS property filter is present, where 2.7.3 is used.

Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.