Opened 4 years ago

Closed 3 years ago

#3956 closed defect (fixed)

abp2blocklist doesn't generate rules from domain whitelisting filters

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: sebastian Blocked By:
Blocking: #3687 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340694/

Description (last modified by kzar)

Environment

NodeJS 5.10.0
abp2blocklist 349d23311c0c

How to reproduce

echo '@@||example.com^$document' | node abp2blocklist.js

Observed behaviour

Result is an empty array []

Expected behaviour

Result should be

[{trigger: {"url-filter": ".*",
            "if-domain": ["example.com", "www.example.com"]},
  action: {type: "ignore-previous-rules"}}]

Notes

  • This is blocking the adding support for content blockers to Safari as it is breaking website whitelisting.
  • Wildcards and paths are not supported for if-domain, so we will have to ignore $document whitelisting rules that use either of those.

Change History (6)

comment:1 Changed 4 years ago by kzar

  • Description modified (diff)

comment:2 Changed 4 years ago by kzar

  • Description modified (diff)

comment:3 Changed 4 years ago by kzar

  • Description modified (diff)

comment:4 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/abp2blocklist/rev/36bcf3e032cc

comment:6 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.