Opened on 04/19/2016 at 03:06:23 PM

Closed on 05/17/2016 at 11:34:25 AM

#3956 closed defect (fixed)

abp2blocklist doesn't generate rules from domain whitelisting filters

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: sebastian Blocked By:
Blocking: #3687 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


NodeJS 5.10.0
abp2blocklist 349d23311c0c

How to reproduce

echo '@@||^$document' | node abp2blocklist.js

Observed behaviour

Result is an empty array []

Expected behaviour

Result should be

[{trigger: {"url-filter": ".*",
            "if-domain": ["", ""]},
  action: {type: "ignore-previous-rules"}}]


  • This is blocking the adding support for content blockers to Safari as it is breaking website whitelisting.
  • Wildcards and paths are not supported for if-domain, so we will have to ignore $document whitelisting rules that use either of those.

Attachments (0)

Change History (6)

comment:1 Changed on 04/20/2016 at 01:01:22 PM by kzar

  • Description modified (diff)

comment:2 Changed on 04/20/2016 at 02:36:14 PM by kzar

  • Description modified (diff)

comment:3 Changed on 04/20/2016 at 02:36:43 PM by kzar

  • Description modified (diff)

comment:4 Changed on 04/20/2016 at 05:17:26 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 05/17/2016 at 11:33:42 AM by abpbot

A commit referencing this issue has landed:

comment:6 Changed on 05/17/2016 at 11:34:25 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.