Opened 4 years ago

Last modified 4 years ago

#3956 closed defect

abp2blocklist doesn't generate rules from domain whitelisting filters — at Version 2

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: sebastian Blocked By:
Blocking: #3687 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


NodeJS 5.10.0
abp2blocklist 349d23311c0c

How to reproduce

echo '@@||^$document' | node abp2blocklist.js

Observed behaviour

Result is an empty array []

Expected behaviour

Result should be

[{trigger: {"url-filter": ".*",
            "if-domain": ["", ""]},
  action: {type: "ignore-previous-rules"}}]


  • This is blocking the adding support for content blockers to Safari as it is breaking website whitelisting.
  • Wildcards are paths are not supported for if-domain, so we will have to ignore $document whitelisting rules that use either of those.

Change History (2)

comment:1 Changed 4 years ago by kzar

  • Description modified (diff)

comment:2 Changed 4 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.