Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3960 closed defect (fixed)

Console errors from contentPolicy and cssProperties

Reported by: Ross Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #2401 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29340656/

Description

Environment

ABP 2.7.2.4163

Reproduced with:
Firefox 43 / 45 / Windows 8

How to reproduce

  1. Launch Firefox open the Firefox console (CTRL+SHIFT+J).
  2. Install the latest ABP dev build.
  3. Perform a Google search (any query) from the search field in Firefox (top right).
  4. Observe errors in the console.

Observed behaviour

The following errors appear in the console:

whitelistMatch is not defined contentPolicy.js 277:0
whitelistMatch is not defined contentPolicy.js 277:0
TypeError: this.patterns is undefined cssProperties.js 140:1

Expected behaviour

No errors to occur.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Blocking 2401 added
  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/b755cde55566

comment:4 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-2.7.3-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

ABP 2.7.2.4165
Firefox 43 / 45 / Windows 8

Note: See TracTickets for help on using tickets.