Opened 4 years ago

Closed 4 years ago

#3962 closed change (fixed)

Update developer tools module paths in Element Hiding Helper

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.3.8
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340697/

Description (last modified by trev)

Background

Bug 912121 changed the location gDevTools.jsm, it is no longer resource:///modules/devtools/gDevTools.jsm but resource://devtools/client/framework/gDevTools.jsm. While the former still works in Firefox 44 and above, there is a huge and ugly warning about it in the Browser Console.

Console.jsm also moved from resource://gre/modules/devtools/Console.jsm to resource://gre/modules/Console.jsm.

What to change

Make Element Hiding Helper go for resource://devtools/client/framework/gDevTools.jsm and only try resource:///modules/devtools/gDevTools.jsm as fallback.

Similarly, try resource://gre/modules/Console.jsm and only then resource://gre/modules/devtools/Console.jsm for console.

Change History (6)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Firefox

comment:2 Changed 4 years ago by trev

  • Description modified (diff)

comment:3 Changed 4 years ago by trev

  • Summary changed from Update path to gDevTools.jsm in Element Hiding Helper to Update developer tools module paths in Element Hiding Helper

comment:4 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/elemhidehelper/rev/46297ca598b9

comment:6 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.