Opened on 04/20/2016 at 05:38:48 PM

Closed on 04/21/2016 at 01:57:54 PM

#3962 closed change (fixed)

Update developer tools module paths in Element Hiding Helper

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.3.8
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)


Bug 912121 changed the location gDevTools.jsm, it is no longer resource:///modules/devtools/gDevTools.jsm but resource://devtools/client/framework/gDevTools.jsm. While the former still works in Firefox 44 and above, there is a huge and ugly warning about it in the Browser Console.

Console.jsm also moved from resource://gre/modules/devtools/Console.jsm to resource://gre/modules/Console.jsm.

What to change

Make Element Hiding Helper go for resource://devtools/client/framework/gDevTools.jsm and only try resource:///modules/devtools/gDevTools.jsm as fallback.

Similarly, try resource://gre/modules/Console.jsm and only then resource://gre/modules/devtools/Console.jsm for console.

Attachments (0)

Change History (6)

comment:1 Changed on 04/20/2016 at 05:39:13 PM by trev

  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Firefox

comment:2 Changed on 04/20/2016 at 05:42:55 PM by trev

  • Description modified (diff)

comment:3 Changed on 04/20/2016 at 05:52:00 PM by trev

  • Summary changed from Update path to gDevTools.jsm in Element Hiding Helper to Update developer tools module paths in Element Hiding Helper

comment:4 Changed on 04/20/2016 at 05:54:06 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 04/21/2016 at 01:57:20 PM by abpbot

A commit referencing this issue has landed:

comment:6 Changed on 04/21/2016 at 01:57:54 PM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.