Opened 4 years ago

Closed 2 years ago

#3967 closed change (fixed)

Create directories for mapped files if they don't already exist

Reported by: kzar Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords: goodfirstbug
Cc: sebastian, kvas, jsonesen, tlucas, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29490563

Description (last modified by kzar)

Background

The metadata files support a [mapping] section which allows files to be placed in different locations or given different names when the extensions are built. Currently if the target location for a mapped file is given inside a directory that's not already included it will be skipped.

What to change

Update packager.py so that readMappedFiles only skips over ignored files. For files inside a not included path the path should be added to the self.includedFiles set instead of being skipped.

Change History (13)

comment:1 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by kzar

  • Blocking 3816 removed
  • Priority changed from P2 to Unknown

If we go with the new approach as of #3968 then this no longer blocks #3816. Still I don't think this change is a bad idea, unless you object I'll keep it open.

comment:3 Changed 3 years ago by kzar

  • Priority changed from Unknown to P5
  • Ready set

comment:4 Changed 3 years ago by kzar

  • Cc kvas jsonesen added
  • Description modified (diff)
  • Owner kzar deleted
  • Review URL(s) modified (diff)

comment:5 Changed 3 years ago by kzar

  • Status changed from reviewing to reopened

comment:6 Changed 2 years ago by sebastian

Also see #5346.

comment:7 Changed 2 years ago by kzar

  • Review URL(s) modified (diff)

comment:8 Changed 2 years ago by sebastian

  • Keywords goodfirstbug added
  • Priority changed from P5 to P3

comment:9 Changed 2 years ago by tlucas

  • Cc tlucas added
  • Owner set to tlucas

comment:10 Changed 2 years ago by greiner

  • Cc greiner added

comment:11 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:12 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 3967 - Create directories for mapped files when necessary

comment:13 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.