Opened 3 years ago

Closed 3 years ago

#3968 closed change (fixed)

Rename options.{html,css,js} to new-options.{html,css,js}

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: #3816 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340737/

Description

Background

In issue #3816 we're adding experimental support for the new options page into Adblock Plus for Chrome, Opera and Safari. Users will still use the old options page but this way we'll be able to use the new options page for development and QA purposes.

As both the old and new options page will be supported by the extension some of the filenames are going to clash, for example options.html.

What to change

Rename options.html, options.js and options.css to new-options.html, new-options.js and new-options.css respectively. Change any references to those filenames where necessary so that everything continue to work as before.

Change History (6)

comment:1 Changed 3 years ago by kzar

What do you think Thomas?

Me and Sebastian discussed the various options for getting the new options page working in adblockpluschrome and this seemed the simplest/cleanest. If you're OK with it I'll happily assign myself and make the changes.

comment:2 Changed 3 years ago by greiner

  • Priority changed from Unknown to P2
  • Ready set

Maybe at some point we could have separate metadata.* files for devbuilds to avoid those conflicts but I assume that'd be too much work for now so fine with me.

comment:3 Changed 3 years ago by kzar

  • Owner set to kzar

comment:4 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/47d8c208c3e9

comment:6 Changed 3 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.