Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#399 closed change (fixed)

Generate update manifests for Safari releases

Reported by: trev Assignee: sebastian
Priority: P1 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6282067956465664

Description

Background

sitescripts.extensions.bin.updateDownloadLinks script is currently responsible for both retrieving download links for the most current release and generating update manifests. However, it can currently only generate update manifests for Gecko and Android extensions.

What to change

Add support for Safari update manifests so that these manifests are also generated.

Change History (7)

comment:1 Changed 6 years ago by sebastian

  • Owner set to sebastian
  • Status changed from new to assigned

comment:2 Changed 6 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:3 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 6 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

The script errored out on the server:

subprocess.CalledProcessError: Command '['hg', '-R', '.../hg/adblockplusie', 'cat', '-r', 'tip', '.../hg/adblockplusie/metadata']' returned non-zero exit status 1

Sounds like a check is missing to skip unknown repository types. The unknown repository types exists because the same configuration is used for devbuilds.

comment:6 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:7 Changed 5 years ago by sebastian

  • Cc sebastian removed
Note: See TracTickets for help on using tickets.