Opened 4 years ago

Closed 4 years ago

#3991 closed defect (fixed)

Homepage URL is no longer being set automatically

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Core Keywords:
Cc: snoack Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340834/

Description

Environment

Adblock Plus 2.7.2.4167-beta

How to reproduce

  1. Create a file filters.txt:
[Adblock Plus 2.0]
! Homepage: http://example.com/
  1. Add this file as a filter subscription ("Add different subscription", then something like file:///foo/bar/filters.txt as URL).

Observed behaviour

The filters are downloaded but no homepage URL appears for this subscription.

Expected behaviour

Homepage URL should be set to http://example.com/ automatically.

Background

This is a regression from https://codereview.adblockplus.org/29339343, the changes there haven't been tested apparently.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/5d9618f68a0c

comment:3 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.