Opened 19 months ago

Closed 2 months ago

Last modified 6 weeks ago

#3994 closed change (fixed)

Do not register ABB to Androids AccountManager

Reported by: scheer Assignee: jwangenheim
Priority: P4 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29542628/

Description (last modified by diegocarloslima)

As we removed Firefox Sync (See #2350, #2417, #2474, #2480, #2785) we should not register ABB to Androids AccountManager anymore.

Observed behaviour

Duplications of 'Firefox' (one with the ABB icon and one with the Firefox icon).
Duplications of 'Firefox Sync (deprecated)' (One with the ABB icon and one with the Firefox icon).

Expected behaviour

ABB should not show up in Device Settings -> Account -> Add account anymore.

Attachments (1)

Screenshot_2016-04-27-09-57-00.png (222.5 KB) - added by scheer 19 months ago.

Download all attachments as: .zip

Change History (12)

Changed 19 months ago by scheer

comment:1 Changed 19 months ago by scheer

  • Description modified (diff)

comment:2 Changed 3 months ago by diegocarloslima

  • Priority changed from Unknown to P4

comment:3 Changed 2 months ago by jwangenheim

  • Description modified (diff)
  • Summary changed from ABB duplicates Firefox and Firefox Sync (deprecated) wording for ABB when adding an account on the device to Do not register ABB into Androids AccountManager
  • Type changed from defect to change

comment:4 Changed 2 months ago by jwangenheim

  • Summary changed from Do not register ABB into Androids AccountManager to Do not register ABB to Androids AccountManager

comment:5 Changed 2 months ago by jwangenheim

  • Owner set to jwangenheim

comment:6 Changed 2 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 months ago by abpbot

A commit referencing this issue has landed:
Issue 3994 - Do not register ABB to Androids AccountManager

comment:8 Changed 2 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 2 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Ready set

comment:10 Changed 8 weeks ago by diegocarloslima

  • Description modified (diff)

comment:11 Changed 6 weeks ago by traynard

  • Verified working set

Verified in KitKat - Oreo

Note: See TracTickets for help on using tickets.