Opened 3 years ago

Closed 3 years ago

#3999 closed change (fixed)

Response to filters.get/cssproperties message should contain filter text

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #3969, #4000 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340898/

Description

Background

For #3969 we need to count hits of matching CSS property filters. For that the content script needs to know the actual filter text, the current response data.

What to change

When responding to the filters.get message requesting CSS property filters, there should be a text field containing full filter text.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Blocking 4000 added

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/f0daa0b325ed

comment:4 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.