Opened 6 years ago

Closed 6 years ago

Last modified 22 months ago

#4 closed change (fixed)

Add high-DPI versions of Chrome/Safari icons

Reported by: trev Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sven Blocked By: #3
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5838171610808320/
http://codereview.adblockplus.org/5700138072801280/
http://codereview.adblockplus.org/5085502482939904/

Description (last modified by trev)

Both Chrome and Safari allow adding high-DPI icons for Retina displays - 38x38 for Chrome and 32x32 for Safari. The agreement here is that we are going with a larger version of the current icon for now, without any additional details.

Attachments (2)

icons_38x38.zip (16.2 KB) - added by sven 6 years ago.
icons_32x32.zip (15.2 KB) - added by sven 6 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by sven

32x32 and 38x38 icons are attached.

Changed 6 years ago by sven

Changed 6 years ago by sven

comment:2 Changed 6 years ago by trev

  • Description modified (diff)

comment:3 follow-up: Changed 6 years ago by philll

  • Cc sven added
  • in_progress set to 0
  • Ready unset

@sven: Which of those attachments shall be used? Please specify in the description eg by linking to the desired one.

comment:4 in reply to: ↑ 3 Changed 6 years ago by philll

Replying to philll:

@sven: Which of those attachments shall be used? Please specify in the description eg by linking to the desired one.

Removed the unnecessary attachments as demanded by sven. Still I recommend to be the description explicit better than implicit and link to the respective attachment where they should be referenced.

comment:5 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 6 years ago by trev

  • Status changed from reviewing to reopened

comment:7 Changed 6 years ago by trev

  • Owner set to sebastian
  • Status changed from reopened to assigned

comment:8 Changed 6 years ago by trev

  • Status changed from assigned to reviewing

comment:9 Changed 6 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 6 years ago by sebastian

  • Review URL(s) modified (diff)

comment:11 Changed 6 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Platform
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

comment:12 Changed 6 years ago by sebastian

  • Ready set

comment:13 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
GitLab Issue 4 - Update navigation menus

Note: See TracTickets for help on using tickets.