Opened 3 years ago

Closed 3 years ago

#4001 closed change (fixed)

Update dependency on adblockpluscore to revision d576e2dac412

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340904/

Description

Background

This update will import #3998 and allow simplifying logic in Firefox.

What to change

No need to emulate ext.backgroundPage.sendMessage() in Firefox, a proper callback can be passed to CSSPropertyFilters constructor now.

What to test

CSS property filters functionality should still work.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/19b8454c9e2f

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.