Opened 3 years ago

#4011 new change

The types of character and used in the code are inconsistent.

Reported by: sergz Assignee:
Priority: P5 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: oleksandr, eric@… Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Take a look for example at src/plugin/PluginFilter.cpp
firstTag is wchar_t
filterSuffix is std::wstring
'*', '[', '.', '#' are char.
In addition, std::iswalnum should be used instead of isalnum.

It is correct for the currently used characters but the code looks dirty.

What to change

  • check places and files
  • use L'<character>' and wide versions of functions.

Change History (0)

Note: See TracTickets for help on using tickets.