Opened 3 years ago

Closed 3 years ago

Last modified 22 months ago

#4020 closed defect (fixed)

In Edge, rawSender.url is not always defined

Reported by: scottlow Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sebastian, oleksandr Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29342909/

Description

There are certain cases where rawSender.url in /ext/background.js is not always defined. As a result, we recommend that the line that reads url: new URL(rawSender.url), actually read url: rawSender.url ? new URL(rawSender.url): '',

Change History (11)

comment:1 Changed 3 years ago by sebastian

  • Cc sebastian oleksandr added

comment:2 Changed 3 years ago by sebastian

What are the cases when url isn't given?

comment:3 Changed 3 years ago by scottlow

The only one I've run into so far is coming from extension-served (ms-browser-extension://) pages. Either way, putting in the null check will ensure there are no failures until we've properly enumerated all cases.

comment:4 Changed 3 years ago by oleksandr

  • Keywords edge added

comment:5 Changed 3 years ago by oleksandr

  • Platform changed from Internet Explorer to Edge

comment:6 Changed 3 years ago by oleksandr

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 years ago by sebastian

  • Keywords edge removed

comment:8 Changed 3 years ago by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 3 years ago by sebastian

  • Sensitive unset

comment:10 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4020 - In Edge, rawSender.url is not always defined

comment:11 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Hasn't introduced any issues. I tested this through general use and messing around in extension served pages (first run, options etc.) looking for errors.

ABP 0.9.11.1849
Edge 40 / Windows 10

ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10

ABP 2.99.0.1838beta
Firefox 50 / 55 / Windows 10

Note: See TracTickets for help on using tickets.