Opened 4 years ago

Last modified 4 years ago

#4021 closed defect

The logic that checks for Edge is incorrect in adblockplusedge — at Initial Version

Reported by: scottlow Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sebastian, oleksandr Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29342906/

Description

In the adblockplusedge repository, there is code that checks for Edge by doing the following: if (!("chrome" in window)). Unfortunately, we do have a chrome object, so this is not a suitable differentiator. The logic we recommend instead is if (typeof browser != 'undefined').

Change History (0)

Note: See TracTickets for help on using tickets.