Opened 4 years ago

Closed 3 years ago

#4027 closed change (fixed)

Make Adblock Plus for Edge download available for the website visitors

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: oleksandr, sebastian, christiane, athornburgh Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29341378/

Description (last modified by saroyanm)

Background

With #2843 we have created a new landing page for Microsoft edge users, but currently we do not have any link or button allowing users to download the build, while the ABP is already available for Edge/14.14342 build and later.

What to change

Add a regular Install button to the Microsoft Edge page for users with Edge/14.14342 builds and later (linking to: ms-windows-store://pdp/?ProductId=9nblggh4r9nz ),so users can download the build from the current page, for all other users update the message to "Adblock Plus is currently available only to Windows Insiders on a build 14342 or higher".
Also update existing image with current one.

Attachments (2)

edge_teaser.png (49.8 KB) - added by saroyanm 4 years ago.
edge_teaser.2.png (13.6 KB) - added by saroyanm 3 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 4 years ago by saroyanm

  • Resolution set to invalid
  • Status changed from new to closed

While it's not widely accessible this issue is on hold right now. We will need to update the page after the build will be accessible for general public, that will still take few month. Marking as invalid for now.

comment:2 Changed 4 years ago by oleksandr

  • Cc oleksandr added
  • Resolution invalid deleted
  • Status changed from closed to reopened

We have actually agreed that we should publish the installation button for users who are visiting our homepage on a supported version of Windows. The currently supported version has this in User Agent Edge/14.14342, where 14342 is a Windows build number, which will be iterated in future. We should show the Edge install button for all users who are on 14342 or later. For all other users we should change the message to "Adblock Plus is currently available only to Windows Insiders on a build 14342 or higher"

Last edited 4 years ago by oleksandr (previous) (diff)

comment:3 Changed 4 years ago by sebastian

  • Cc sebastian added

comment:4 follow-up: Changed 4 years ago by saroyanm

  • Description modified (diff)

I have several questions:

  1. Is there a way to download the build directly from adblockplus.org or should we link users to -> https://www.microsoft.com/en-us/store/apps/adblock-plus/9nblggh4r9nz (I also added this link to the general message just in case we will have problem with detection)
  2. Do we expect Edge/14 also grow, so should the regular expression match also Edge/15.10001 ?
  3. Should the ABP for Edge image be replaced by the regular video ? Or we would like to keep the image so people will understand that it's somehow in Beta.

Note: Having JavaScript detection while we have Edge page should be enough I assume, I think we do not need to create separate landing page for the reason of detection.

Last edited 4 years ago by saroyanm (previous) (diff)

comment:5 in reply to: ↑ 4 Changed 4 years ago by sebastian

Replying to saroyanm:

I have several questions:

  1. Is there a way to download the build directly from adblockplus.org or should we link users to -> https://www.microsoft.com/en-us/store/apps/adblock-plus/9nblggh4r9nz (I also added this link to the general message just in case we will have problem with detection)

As far as I understand we could also use a ms-windows-store:// URL for a better user experience.

  1. Do we expect Edge/14 also grow, so should the regular expression match also Edge/15.10001 ?

Yeah, we have to match Edge/14.14342, Edge/14.14343, ..., Edge/15, ...

  1. Should the ABP for Edge image be replaced by the regular video ? Or we would like to keep the image so people will understand that it's somehow in Beta.

Good point, and I agree, we should probably communicate it as a beta version. Perhaps just call it "Adblock Plus beta" on /edge? The "comming soon" image however wouldn't make much sense.

Note: Having JavaScript detection while we have Edge page should be enough I assume, I think we do not need to create separate landing page for the reason of detection.

Yeah, I think for distinguishing Edge/14.14342+ from older Edge versions JavaScript detection should be good enough.

Last edited 4 years ago by sebastian (previous) (diff)

comment:6 Changed 4 years ago by saroyanm

  • Cc christiane athornburgh added
  • Description modified (diff)

As far as I understand we could also use a ms-windows-store:// URL for a better user experience.

Done

Changed 4 years ago by saroyanm

comment:7 Changed 4 years ago by saroyanm

@AAron, @Christiane: We would like to communicate through the update of existing "Coming soon" image on Edge page that it's already available in Beta, I've updated the image with a message on top -> https://issues.adblockplus.org/attachment/ticket/4027/edge_teaser.png , please let me know if it's Okey with you and I can use that image, otherwise, can you please provide a new one please, or let me know if I need to do some changes on that image if it will be easier for you, thanks in advance.

comment:8 Changed 4 years ago by saroyanm

  • Description modified (diff)

comment:9 Changed 4 years ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

So @Aaron is in favor of creating new image, but I do not want to block this issue meanwhile so I'll change the image in separate issue so we can go through the codereview for the detection part without being blocked, I'll align with him again as soon current review is done regarding existing image, before pushing the changes.

comment:10 Changed 4 years ago by saroyanm

  • Owner set to saroyanm

comment:11 Changed 4 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

Changed 3 years ago by saroyanm

comment:12 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:13 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/web.adblockplus.org/rev/c8d6ff103286

comment:14 Changed 3 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed 3 years ago by saroyanm

  • Resolution fixed deleted
  • Status changed from closed to reopened

Apparently we only need to check for windows build number as mentioned in the current review

comment:16 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/web.adblockplus.org/rev/3d514491ca00

comment:17 Changed 3 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.