Opened 3 years ago

Closed 3 years ago

#4029 closed defect (fixed)

SharedPreference related crash on filter list fetch

Reported by: rjeschke Assignee:
Priority: P1 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29341124/

Description

See #3931 for more background information.

The fix applied to tackle issue #3931 didn't do the trick, apparently, and the crash still appears.

This time we should make the preference query itself bullet proof.

Change History (5)

comment:1 Changed 3 years ago by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussbrowser/rev/f61cbc5a9b58

comment:3 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • No crashes have been observed when the user pushes for new filters.

Adblockplussbrowser-1.0.3-20160513123700-signed
Samsung Galaxy S5/S6
Android 5.0.1/6.0

comment:4 Changed 3 years ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.3

comment:5 Changed 3 years ago by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.