Opened 4 years ago

Closed 13 months ago

#4030 closed change (fixed)

Move JNI bindings into separate library project

Reported by: rjeschke Assignee: asmirnov
Priority: P3 Milestone:
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #4031, #4115, #4260 Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345540/

Description

Background

The proxy application for Android contains JNI bindings for libadblockplus. As we do have users that use those JNI bindings in their own projects, it would be convenient to have those inside a separate project.

What to change

Create a library project (libadblockplus-android), compatible with gradle, maven and manual importing. Move the JNI specific parts from adblockplusandroid into the new project.

Things of importance for moving:

  • the whole `org.adblockplus.libadblockplus' package
  • ensure_dependencies.py with buildtools and jni/libadblockplus-binaries
  • the jni folder

For the initial version of this library, no code should be modified except that it is needed for the library to build. A README.md for usage and build instructions should also be set up.

Change History (10)

comment:1 Changed 4 years ago by rjeschke

  • Ready set

comment:2 Changed 4 years ago by rjeschke

  • Blocking 4031 added

comment:3 Changed 4 years ago by Anton

  • Owner set to Anton

comment:4 Changed 4 years ago by asmirnov

  • Owner changed from Anton to asmirnov

comment:5 Changed 4 years ago by asmirnov

splitted into library and app. added maven module descriptor to build aar (library only)

comment:6 Changed 3 years ago by asmirnov

  • Blocking 4115 added

comment:7 Changed 3 years ago by asmirnov

  • Status changed from new to reviewing

comment:8 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:9 Changed 3 years ago by asmirnov

  • Blocking 4260 added

comment:10 Changed 13 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.