Opened 3 years ago

Closed 4 weeks ago

#4031 closed change (fixed)

Implement tests for libadblockplus-android

Reported by: rjeschke Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By: #4030, #4160, #4176, #4177, #4178
Blocking: #4080, #4081, #4086, #4146, #4180, #4181 Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29344967/

Description

Background

We need to set up tests for the new libadblockplus-android project.

What to change

Write tests that focus on testing the JNI bindings, i.e. the Java side, as the functional side is covered by `libadblockplus`. Having a basic testing of the underlying functionality shouldn't be removed completely, as those can also indicate a problem in the glue code.

Change History (20)

comment:1 Changed 3 years ago by Anton

  • Owner set to Anton

comment:2 Changed 3 years ago by asmirnov

  • Owner changed from Anton to asmirnov

comment:3 Changed 3 years ago by sergz

  • Cc sergz added

comment:4 Changed 2 years ago by rjeschke

  • Component changed from Libadblockplus to Libadblockplus-Android

comment:5 Changed 2 years ago by philll

  • Summary changed from Implement tests to Implement tests for libadblockplus-android

comment:6 Changed 2 years ago by asmirnov

  • Blocking 4080 added

comment:7 Changed 2 years ago by asmirnov

  • Blocking 4081 added

comment:8 Changed 2 years ago by asmirnov

  • Blocking 4086 added

comment:9 Changed 2 years ago by asmirnov

  • Blocking 4146 added

comment:10 Changed 2 years ago by asmirnov

  • Status changed from new to reviewing

comment:11 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)

comment:12 Changed 2 years ago by asmirnov

  • Blocked By 4160 added

comment:13 Changed 2 years ago by asmirnov

  • Blocked By 4176 added

comment:14 Changed 2 years ago by asmirnov

  • Blocked By 4177 added

comment:15 Changed 2 years ago by asmirnov

  • Blocked By 4178 added

comment:16 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4031 - Implement tests for libadblockplus-android

comment:17 Changed 2 years ago by asmirnov

  • Blocking 4180 added

comment:18 Changed 2 years ago by asmirnov

  • Blocking 4181 added

comment:19 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4031 - Implement tests for libadblockplus-android

comment:20 Changed 4 weeks ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.