Changes between Initial Version and Version 1 of Ticket #4036


Ignore:
Timestamp:
05/11/2016 03:01:14 PM (14 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4036 – Description

    initial v1  
    2121 - I don't think this is down to a deopt with new Chrome versions, or at least the profiler doesn't show any deoptimisation warnings. (See the attached screenshot.) 
    2222 - [https://adblockplus.org/forum/viewtopic.php?p=150955 See related discussion in the forum] (Note: The title seems incorrect, it seems that the problem started with version 51 not 50.) 
     23 - The problem seems to be caused by [https://github.com/adblockplus/adblockpluschrome/blob/master/include.preload.js#L462-L466 the while loop inside addElemHideSelectors] somehow. When that is commented out the problem goes away.    (The problem does not go away when only the style.sheet.addRule line is commented so it looks like the problem could be with the line above.)